fix(umoci)!: umoci's copy buffer set to 1 MiB #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchamarthy
requested changes
Oct 25, 2023
Targeting ecosystem compatibility. opencontainers/image-spec#1145 |
Codecov Report
@@ Coverage Diff @@
## main #531 +/- ##
=======================================
Coverage 13.14% 13.14%
=======================================
Files 40 40
Lines 5943 5943
=======================================
Hits 781 781
Misses 5034 5034
Partials 128 128 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
rchincha
force-pushed
the
gzip
branch
2 times, most recently
from
def473f to
bc3756a
Compare
raharper
reviewed
Nov 1, 2023
raharper
reviewed
Nov 2, 2023
rchincha
force-pushed
the
gzip
branch
9 times, most recently
from
f8c8665 to
0b00592
Compare
raharper
reviewed
Nov 3, 2023
rchincha
force-pushed
the
gzip
branch
4 times, most recently
from
cce6af5 to
c52d459
Compare
raharper
reviewed
Nov 3, 2023
rchincha
force-pushed
the
gzip
branch
4 times, most recently
from
b3d3ec6 to
461496c
Compare
project-stacker/umoci@89a7ea1 Use updated umoci (project-stacker's fork) to use a 1 MiB copy buffer. This change brings stacker inline with compression parameters used in containers/image libraries and makes them compatible. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
|
$BATS_TEST_TMPDIR is a temporary directory unique for each test. Could be used to create files required only for specific tests. |
rchincha
force-pushed
the
gzip
branch
5 times, most recently
from
5d46601 to
d11d441
Compare
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
added a commit
to rchincha/stacker
that referenced
this pull request
Nov 8, 2023
* fix(umoci)!: umoci's copy buffer set to 1 MiB project-stacker/umoci@89a7ea1 Use updated umoci (project-stacker's fork) to use a 1 MiB copy buffer. This change brings stacker inline with compression parameters used in containers/image libraries and makes them compatible. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> * test(gzip): add unit tests for gzip Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> --------- Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> (cherry picked from commit 589a648) Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project-stacker/umoci@89a7ea1
Use updated umoci (project-stacker's fork) to use a 1 MiB copy buffer. This change brings stacker inline with compression parameters used in containers/image libraries and makes them compatible.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.