Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upload stacker binary #556

Merged
merged 1 commit into from
Nov 20, 2023
Merged

ci: Upload stacker binary #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,14 @@ jobs:
REGISTRY_URL: localhost:5000
ZOT_HOST: localhost
ZOT_PORT: 8080
- name: Upload artifacts
uses: actions/upload-artifact@v3
if: ${{ matrix.privilege-level == 'priv' }}
with:
# if there is more than 1 go-version, we would need to account for that here.
name: binary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: stacker
^ instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want we can call it stacker. but what that creates is a zip file name 'stacker.zip' which contains stacker. I'd prefer 'binaries' or 'binary' as its an archive (potentially multiple things).

So its not like it is a single thing that that you can download it and use it, in which case 'stacker' and 'stacker-cov' would be the right name.

I'll rename it if you want though.

path: stacker
if-no-files-found: error
- name: Show disk usage before running the tests
if: always()
uses: ./.github/actions/show-disk-usage
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ jobs:
REGISTRY_URL: localhost:5000
ZOT_HOST: localhost
ZOT_PORT: 8080
- name: Upload artifacts
uses: actions/upload-artifact@v3
if: ${{ matrix.privilege-level == 'priv' }}
with:
# if there is more than 1 go-version, we would need to account for that here.
name: binary-cov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here?

path: stacker
if-no-files-found: error
- name: Show disk usage after running the tests
if: always()
uses: ./.github/actions/show-disk-usage
Expand Down
Loading