Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix a failing test #606

Merged
merged 1 commit into from
Mar 23, 2024
Merged

ci: fix a failing test #606

merged 1 commit into from
Mar 23, 2024

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.46%. Comparing base (42e845f) to head (722d99e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   57.46%   57.46%           
=======================================
  Files          65       65           
  Lines        7709     7709           
=======================================
  Hits         4430     4430           
  Misses       2522     2522           
  Partials      757      757           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Looks like missed one more place

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha rchincha changed the title Fix ci ci: fix a failing test Mar 23, 2024
@rchincha rchincha marked this pull request as ready for review March 23, 2024 16:53
@rchincha rchincha requested review from smoser and hallyn as code owners March 23, 2024 16:53
@rchincha rchincha merged commit 1996784 into project-stacker:main Mar 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant