build: improve errors for --oci-dir cases #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemccracken
requested review from
rchincha,
smoser and
hallyn
as code owners
|
I'm not liking the PathExists() fn, but you didn't write it, so let's ignore that. however: callers need to be updated. |
mikemccracken
force-pushed
the
2024.09.09/main/better-errors-oci-dir
branch
from
dbbe10a
to
7af1dfa
Compare
If the argument to oci-dir exists but is empty, we currently get a confusing error about it not being a layout. Other cases could be better explained while we're at it too. Signed-off-by: Michael McCracken <mikmccra@cisco.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 63.72% 63.71% -0.02%
==========================================
Files 57 57
Lines 5015 5018 +3
==========================================
+ Hits 3196 3197 +1
+ Misses 1176 1175 -1
- Partials 643 646 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the argument to oci-dir exists but is empty, we currently get a confusing error about it not being a layout. Other cases could be better explained while we're at it too.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.