test: add additional tests for whiteout fixes #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acd8a68 address some breakages related to whiteouts. This PR adds some more verification steps. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 63.72% 63.71% -0.02%
==========================================
Files 57 57
Lines 5015 5018 +3
==========================================
+ Hits 3196 3197 +1
+ Misses 1176 1175 -1
- Partials 643 646 +3 ☔ View full report in Codecov by Sentry. |
rchincha
force-pushed
the
whiteout-test
branch
from
182a7b8
to
8662a58
Compare
hallyn
reviewed
Oct 31, 2024
| EOF | ||
|
|
||
| stacker build | ||
|
|
||
| # "bb" should not have a whiteout entry for /a1 | ||
| md=$(cat oci/index.json | jq .manifests[0].digest | sed s/sha256://g | tr -d \") | ||
| ld=$(cat oci/blobs/sha256/"$md" | jq .layers[-1].digest | sed s/sha256://g | tr -d \") | ||
| "bsdtar -tvf oci/blobs/sha256/$ld | grep '.wh.a1'" |
There was a problem hiding this comment.
Hi,
these look good. Though for this particular hunk, would it be better to not remove this bsdtar|grep, but rather turn it into a bsdtar | grep -v '.wh.a1' ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acd8a68 address some breakages related to whiteouts.
This PR adds some more verification steps.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.