fix: handle whiteout for created dirs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a dir is created, overlayfs adds the opaque xattr. Detect this case and add the dir to the generated tar blob. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
joylatten
reviewed
Sep 4, 2024
| // skip this since previous layers dont have this file/dir | ||
| log.Debugf("skipping whiteout since %s not present in any previous layers", pathInTar) | ||
| return nil | ||
| // overlayfs adds opaque xattr for newly created dirs, |
There was a problem hiding this comment.
does this path ever get hit for files and not just directories?
the old comment said "file/dir" but here we sound like we're assuming it's only dirs. Are there cases where we might have been missing adding a file to the tar also?
rchincha
added a commit
to rchincha/stacker
that referenced
this pull request
Sep 6, 2024
For newly created dirs, overlayfs sets opaque attr which generates a whiteout file in the blob tarball. project-stacker/umoci#11 Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
added a commit
to project-stacker/stacker
that referenced
this pull request
Sep 6, 2024
For newly created dirs, overlayfs sets opaque attr which generates a whiteout file in the blob tarball. project-stacker/umoci#11 Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dir is created, overlayfs adds the opaque xattr. Detect this case and add the dir to the generated tar blob.