Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev fix article list item widget #324

Closed
wants to merge 12 commits into from
Closed

Dev fix article list item widget #324

wants to merge 12 commits into from

Conversation

TaYaKi71751
Copy link
Contributor

@TaYaKi71751 TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

@TaYaKi71751
Fix _ArticleListItemWidgetState._showArticleInfo
Screenshot

@TaYaKi71751
Use FutureBuilder
135720d 
to _ArticleListItemWidgetState._showArticleInfo
@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

Screenshot
I need to fix this with FutureBuilder

@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

Fix _ArticleListItemWidgetState.build
Screenshot

@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

I need to fix this
Screenshot

@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

this typo
Screenshot

@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

It was fixed by fixing typo in pagesUrl

I need to fix this Screenshot

@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

I found this
screenshot

@TaYaKi71751 TaYaKi71751 force-pushed the dev-fix-article-list-item-widget branch from cb304a2 to f910042 Compare January 9, 2024 08:00
@TaYaKi71751 TaYaKi71751 force-pushed the dev-fix-article-list-item-widget branch from f910042 to bcb554c Compare January 9, 2024 08:09
@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 9, 2024 •
edited
Loading

https://github.com/TaYaKi71751/violet-testing-dev-fix-article-list-item-widget/releases/tag/1.30.0-dd9948dc0b265eed340c19be66717e568b1e043b

@TaYaKi71751
Copy link
Contributor Author

https://github.com/TaYaKi71751/violet-testing-dev-fix-article-list-item-widget/releases/tag/1.30.0-7b988d5542195f003d2073c4ab298c5ff193c21f

@TaYaKi71751
Copy link
Contributor Author

TaYaKi71751 commented Jan 11, 2024 •
edited
Loading

새로운 브랜치에서 cherry-pick 및 코멘트와 함께 커밋 정리 후 다시 pr 하겠습니다

@TaYaKi71751 TaYaKi71751 deleted the dev-fix-article-list-item-widget branch January 11, 2024 07:35
@TaYaKi71751
Copy link
Contributor Author

this branch was moved to TaYaKi71751:dev-fix-article-list-item-widget-archive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TaYaKi71751