Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor download page #335

Merged
merged 10 commits into from
Jan 22, 2024
Merged

Refactor download page #335

merged 10 commits into from
Jan 22, 2024

Conversation

violet-dev
Copy link
Member

@violet-dev violet-dev commented Jan 13, 2024

TODO

  • 스크롤에 따라 AZ IndexBar 내용을 변경해야함

@violet-dev violet-dev marked this pull request as draft January 13, 2024 13:15
@violet-dev violet-dev force-pushed the refactor-download-page branch from 7a22027 to ccc1212 Compare January 14, 2024 00:43
@violet-dev violet-dev force-pushed the refactor-download-page branch from ccc1212 to e6c6367 Compare January 14, 2024 01:29
@violet-dev violet-dev force-pushed the refactor-download-page branch 2 times, most recently from c590f89 to c920dd4 Compare January 14, 2024 06:54
@violet-dev violet-dev force-pushed the refactor-download-page branch from db54d13 to e11954d Compare January 14, 2024 09:49
@violet-dev
Copy link
Member Author

violet-dev commented Jan 14, 2024

인덱싱은 맞췄으나 StickyHeader랑 PersistentHeader랑 싱크가 안맞아서 조치 필요
해결하는데 오래 걸릴 듯하여 UI 변경 고려 필요

@violet-dev
Copy link
Member Author

Lazy Load가 안되는 문제가 있음.
맨 위에서 AZList의 맨 아래 아이템을 탭하면 그 탭한 위치부터 맨위까지의 모든 범위의 Item들이 로딩되는 버그가 있다.

아마 viewer page처럼 debounce 로직을 적용하면 해결될 듯한데 이게 옳은 방법인지도 모르겠고,
무엇보다도 메모리의 한계치 까지 이미지를 로딩하고 해제를 안하기 때문에 이부분도 확인이 필요함.
아마 Image.File이라 그럴수도?

@violet-dev
Copy link
Member Author

Bookmark Group Article List에 적용된 Debounce Logic 적용하면 좋을 것 같음

@violet-dev violet-dev marked this pull request as ready for review January 22, 2024 13:39
@violet-dev violet-dev enabled auto-merge January 22, 2024 13:39
@violet-dev violet-dev added this pull request to the merge queue Jan 22, 2024
Merged via the queue into dev with commit 261e4aa Jan 22, 2024
4 checks passed
@violet-dev violet-dev deleted the refactor-download-page branch January 22, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant