-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor download page #335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violet-dev
force-pushed
the
refactor-download-page
branch
from
January 14, 2024 00:43
7a22027
to
ccc1212
Compare
violet-dev
force-pushed
the
refactor-download-page
branch
from
January 14, 2024 01:29
ccc1212
to
e6c6367
Compare
violet-dev
force-pushed
the
refactor-download-page
branch
2 times, most recently
from
January 14, 2024 06:54
c590f89
to
c920dd4
Compare
violet-dev
force-pushed
the
refactor-download-page
branch
from
January 14, 2024 09:49
db54d13
to
e11954d
Compare
인덱싱은 맞췄으나 StickyHeader랑 PersistentHeader랑 싱크가 안맞아서 조치 필요 |
Lazy Load가 안되는 문제가 있음. 아마 viewer page처럼 debounce 로직을 적용하면 해결될 듯한데 이게 옳은 방법인지도 모르겠고, |
Bookmark Group Article List에 적용된 Debounce Logic 적용하면 좋을 것 같음 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy requestTODO