Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: integrated pagination in cve tab #287

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

raulkele
Copy link
Collaborator

Signed-off-by: Raul Kele raulkeleblk@gmail.com

What type of PR is this?
Feature

Which issue does this PR fix:
Closes #284

What does this PR do / Why do we need it:
Integrates the new CVEListForImage query pagination changes into the ui

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #287 (e843e19) into main (cea2fb6) will decrease coverage by 0.15%.
The diff coverage is 89.79%.

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   89.32%   89.17%   -0.15%     
==========================================
  Files          47       47              
  Lines        1208     1238      +30     
  Branches      290      299       +9     
==========================================
+ Hits         1079     1104      +25     
- Misses        118      123       +5     
  Partials       11       11              
Impacted Files Coverage Δ
src/api.js 61.29% <50.00%> (-1.01%) ⬇️
src/components/VulnerabilitiesDetails.jsx 91.30% <90.00%> (-2.73%) ⬇️
src/components/TagDetails.jsx 97.18% <100.00%> (+0.16%) ⬆️
src/utilities/objectModels.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Raul Kele <raulkeleblk@gmail.com>
@raulkele raulkele force-pushed the patch/cve-pagination branch from 470e698 to e843e19 Compare January 26, 2023 11:47
Copy link
Contributor

@ameliamariabreda ameliamariabreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@raulkele raulkele merged commit a4b25ad into project-zot:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zui: CVE pagination
2 participants