feat: add freebsd as an OS filter (#407) #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raulkele can u take a look pls? |
|
@dfr, can you pls take a look at CI failures? |
Signed-off-by: Doug Rabson <dfr@rabson.org>
I think I have fixed the CI failure. I'll spend a bit more time figuring out how to run these tests locally. |
rchincha
requested review from
andaaron,
eusebiu-constantin-petu-dbk and
Andreea-Lupu
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 55 55
Lines 1664 1664
Branches 436 436
=======================================
Hits 1457 1457
Misses 196 196
Partials 11 11 ☔ View full report in Codecov by Sentry. |
andaaron
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
#407
What does this PR do / Why do we need it:
It is useful to be able to filter by OS and I typically have both linux and freebsd images in my repositories.
Testing done on this change:
Ad-hoc testing with zot. I added a test for filtering for freebsd, similar to windows but haven't managed to run that test locally. Hopefully CI will work though.
Automation added to e2e:
I modified the 'explore filtering' test to add checks for freebsd as a filter.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No and no.
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
The user will see freebsd listed as an OS filter.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.