Catch yum update/upgrade but ignore other update/upgrade in RUN #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
RUN
has the wordyum
and at some later point the sameRUN
also containsupdate all
,update
, orupgrade
, the condition was being met. However this can break some workflows.For example, the following matches the condition pointlessly because of line 4. No actual
yum upgrade
happens here but the current conditions make it appear that way.Instead, we can match by spaces and/or tabs using
[ \t]+
. This wayyum
, followed by any number of spaces or tabs, followed byupdate all
,update
, orupgrade
would allow the above Dockerfile to pass but the below Dockerfile would fail correctly or as expected.The same change can probably be made to the other installer methods, such as
apt-get
etc.