Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer.py uses the wrong lorax template for the AArch64 architecture. #102

Open
jperrin opened this issue Sep 26, 2016 · 9 comments
Open

Comments

@jperrin
Copy link

jperrin commented Sep 26, 2016

I'm working to get CentOS-7 AArch64 builds of Atomic working. Everything works, with the exception of the grub config generated by the lorax bits in installer.py. It appears to use the grub2-efi template rather than the AArch64 template. This results in an unbootable system. With a corrected grub config, the system boots and runs atomic quite well.

@cgwalters
Copy link
Member

This should likely be filed against rhinstaller/lorax or rhinstaller/anaconda - I don't see anything -toolbox specific here, we're just wrap lorax, right?

@jperrin
Copy link
Author

jperrin commented Sep 28, 2016

I don't think this is a lorax issue, as it ships with a functional aarch64
template for the base distro. In this instance it seems the issue is with
the lorax template created inside the installer.py. since the lorax
template generated by rpm-ostree-toolbox doesn't include the aarch64 lorax
config, the resulting image is incorrect.

On Sep 27, 2016 14:01, "Colin Walters" notifications@github.com wrote:

This should likely be filed against rhinstaller/lorax or
rhinstaller/anaconda - I don't see anything -toolbox specific here, we're
just wrap lorax, right?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#102 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH8hAJVjAzyD_E8zE3LV5qWbQBP7GlfIks5quYQrgaJpZM4KHAhz
.

@cgwalters
Copy link
Member

cgwalters commented Oct 3, 2016

I think I need a shell 💻 🐚 on the system to debug this.

@jberkus
Copy link

jberkus commented Jun 29, 2017

How can we resolve this? I have an ARM64 Box loaded to me by ARM, and they would really like to see Atomic for ARM64 working.

@cgwalters
Copy link
Member

I need more information - like build logs, and exactly what needed to be changed.

Also, presumably this is not an issue in current Fedora with pungi. So another path is to use Pungi for CentOS builds as well.

@jberkus
Copy link

jberkus commented Jun 30, 2017

@jperrin can you help?

@pcdubs
Copy link

pcdubs commented Jul 19, 2017

This is still an issue in Fedora Rawhide, and reproducible using the latest iso to install (Fedora-Rawhide-20170718.n.0). The grub.cfg on the iso is correct, but the resulting installed system uses 'linuxefi/initrdefi' entries in grub.cfg, rather than aarch64 specific 'linux/initrd'.
The error is:
error: can't find command linuxefi'. error: can't find command initrdefi'.

Editing the grub.cfg and correcting to 'linux/initrd' the system boots as expected.

@cgwalters
Copy link
Member

Ah. This sounds related to ostreedev/ostree#716

cgwalters added a commit to cgwalters/ostree that referenced this issue Jul 19, 2017
See: projectatomic/rpm-ostree-toolbox#102 (comment)

The logic here should now match what grubby does.  I have no
idea whether this applies to other distributions though.
@cgwalters
Copy link
Member

PR in ostreedev/ostree#1021 - if someone with an aarch64 machine could try it that'd be great, or just another set of eyeballs on it.

rh-atomic-bot pushed a commit to ostreedev/ostree that referenced this issue Jul 27, 2017
See: projectatomic/rpm-ostree-toolbox#102 (comment)

The logic here should now match what grubby does.  I have no
idea whether this applies to other distributions though.

Closes: #1021
Approved by: jlebon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants