-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component URLs should separate the ead & ref slugs #1318
Comments
#1317 is an idea for a seam for downstream applications to decide what style they want 🤷♂️ |
It's a bit of an esoteric art and I'm not necessarily an expert, but I believe that
Depending on the tool you're using, I think same. If you're going to do the work to make a change (globally or with a "seam" in an individual app), I predict you'll be a lot happier over the long-term, and less likely to need to change it again, if you can go to |
@marlo-longley We are definitely still interested in prioritizing this work. In lieu of having a configurable way to do this, here's what we ended up having to modify in our local 1.0.1-based app:
|
Thank you @seanaery. In earlier comments it seemed like some people had a strong preference for splitting the URL into a new path instead of the underscore separation (so that'd be Your code is really helpful and seems much for straightforward in terms of routing to achieve. I will try to work something with this approach. |
We would want to continue the current URLs in our local instance just for persistence, but I the default should probably be the slash (archives.institution.edu/catalog/slug/aspace_123). I think that is okay if its config that you could just change in catalog_controller or similar and its clearly stated in the release notes how to maintain older-style URLs. |
This breaking change closes #1318
This breaking change closes #1318
This breaking change closes #1318
This breaking change closes #1318
This breaking change closes #1318
This breaking change closes #1318
…red in one place. Advances #1318 - Capture the concatenated/formatted IDs at indexing time, in parent_ids_ssim array - Use that data instead of global_id
…red in one place. Advances #1318 - Capture the concatenated/formatted IDs at indexing time, in parent_ids_ssim array - Use that data instead of global_id
Summary
ArcLight currently creates URLs to individual components like this:
{host}/catalog/{ead_ssi}{ref_ssi}
So we get URLs like:
Collection:
archives.institution.edu/catalog/slug
<-- this is OKComponent:
archives.institution.edu/catalog/slugaspace_123
<-- this is not idealDesired Change
This ticket is a request to improve the component URLs by using one of these conventions instead:
archives.institution.edu/catalog/slug/aspace_123
archives.institution.edu/catalog/slug_aspace_123
Reasons for concern over the smooshed together URL
ead
slugs often end in letters andref
values often begin withal
oraspace
Current ArcLight Usage
No separation in Component URL
These apps follow default core:
Has separation in Component URLs by wedging an underscore between the
ead
&ref
slugsThese apps wedge an underscore between the
ead
&ref
slugs (overriding core):Other Considerations
@gwiedeman & @jrochkind astutely note on
code4lib#arclight
Slack that if a change is made to core, it's important to be able to redirect from the old style to keep existing URLs working. And even if core stays how it is, I recommend making the convention configurable or otherwise straightforward to override globally.The text was updated successfully, but these errors were encountered: