Add DID_SEARCHABLE_NOTES_FIELDS to text search #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlo-longley
force-pushed
the
did-searchable-notes
branch
from
2ba241d
to
a784bc1
Compare
marlo-longley
force-pushed
the
did-searchable-notes
branch
from
a784bc1
to
a49ae6a
Compare
corylown
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these weren't getting indexed to the text bucket before?
See
arclight/lib/arclight/traject/ead2_config.rb
Line 47 in 54bfcb3
and
arclight/lib/arclight/traject/ead2_component_config.rb
Line 60 in 54bfcb3
Also,
did_notedoes not seem to be used anywhere.