Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply title and repository as kwargs for local id forming requirements #1532

Merged
merged 1 commit into from
May 8, 2024

Conversation

corylown
Copy link
Contributor

@corylown corylown commented May 8, 2024

This builds on #1531 to provide a way for applications to customize how the collection id is formed, making it possible to add either the title or repository to the id to fulfill local requirements. This does not change how the default id is formed from the eadid.

Here's an example of how a local application could use this to add a slug form of the title to the collection id: https://github.com/sul-dlss/stanford-arclight/compare/add-title-to-id?expand=1

@marlo-longley
Copy link
Contributor

Looks good to me @corylown. My only suggestion is that we should maybe edit this area of the Wiki about customizing IDs: https://github.com/projectblacklight/arclight/wiki/Indexing-EAD-in-ArcLight#advanced-component_identifier_format-in-arclight

Right now the Wiki / code assumes that the place to customize component ids is the component_identifier_format -- it remains the case that you can customize that using some combination of ref_id and root_id (changing the separator character, etc.). But this PR allows us to change root_id itself, which may be actually the target of where many implementers (like us at Stanford) want to make deeper changes to how IDs appear in the URLs. So anyway, some more info in the Wiki or elsewhere could help make it clear when to use which approach for customizing IDs. It doesn't necc have to be part of this PR.

@corylown
Copy link
Contributor Author

corylown commented May 8, 2024

Thanks for taking a look @marlo-longley. Yeah, we'd want to update the wiki if/when this change is released.

@seanaery seanaery merged commit 373ce44 into main May 8, 2024
4 checks passed
@seanaery seanaery deleted the collection-id-creation branch May 8, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants