allow show tools to be moved to the header, closes #2316 #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnoneill
force-pushed
the
2316-show-tools
branch
3 times, most recently
from
574970c to
3865500
Compare
dnoneill
force-pushed
the
2316-show-tools
branch
from
3865500 to
32cb45b
Compare
jcoyne
requested changes
Aug 15, 2024
app/components/blacklight/document/page_header_component.html.erb
Outdated
Show resolved
Hide resolved
dnoneill
force-pushed
the
2316-show-tools
branch
7 times, most recently
from
908c52a to
d48f51e
Compare
|
@jcoyne I added your suggestions except for the unresolved ones. I also added tests for the PageHeaderComponent and added a show_header_tools_component to the blacklight config. |
jcoyne
requested changes
Aug 19, 2024
jcoyne
reviewed
Aug 19, 2024
dnoneill
force-pushed
the
2316-show-tools
branch
2 times, most recently
from
4141d67 to
2d0e806
Compare
jcoyne
requested changes
Aug 19, 2024
dnoneill
force-pushed
the
2316-show-tools
branch
from
2d0e806 to
7c33004
Compare
jcoyne
previously requested changes
Aug 19, 2024
dnoneill
force-pushed
the
2316-show-tools
branch
4 times, most recently
from
c1d14ac to
507de60
Compare
jcoyne
requested changes
Aug 20, 2024
jcoyne
reviewed
Aug 20, 2024
dnoneill
force-pushed
the
2316-show-tools
branch
2 times, most recently
from
8813204 to
e881b66
Compare
dnoneill
force-pushed
the
2316-show-tools
branch
from
e881b66 to
3929992
Compare
tpendragon
approved these changes
Aug 20, 2024
jcoyne
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new function called add_show_header_tools_partial. This will allow the user to add tools to the page header.
When the app is spun up nothing changes. Changes only go into effect if the user enables these settings.
add_show_header_tools_partial small screen
