Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating when BUNDLE_PATH is set #3286

Closed
wants to merge 1 commit into from
Closed

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Aug 22, 2024

Fixes #3284

@jrochkind
Copy link
Member

I wonder what the heck that with_unbundled_env was for in the first place! Hopefully nothing it was an unneeded accidental addition?

@jrochkind
Copy link
Member

For code archeology... the code (in form of older method with_clean_env seems to have been added here:

b3831f8

With commit message just saying "Update install generators to explicitly run bundle install inside the destination_root". I don't totally understand what that means in this context.

By @cbeer . Should we check with @cbeer to see if he remembers the motivation or any reason this revert would break anything?

@cbeer
Copy link
Member

cbeer commented Aug 27, 2024

with_unbundled_env was for in the first place!

I think the failing CI build demonstrates the kind of failure you get without it. If the CI build can be fixed, great 🤷‍♂️

@jcoyne jcoyne closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator fails when BUNDLE_PATH is set
3 participants