-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textual facets in collapsible on screen #274
Conversation
…irst proof of concept
That looks great to me, @jrochkind . Bonus points for making it configurable. I like the way the |
OK, i18n added, initial non-English translations provided by Google Translate via i18n-tasks. |
@seanaery What do you think about that heading "Range List"? I'm not sure anyone will have any idea what it means... but having trouble coming up with anything. Colleague @eddierubeiz suggests "Number of results in each range", or "Results in each range", or maybe "Results in each interval"... I really don't know. |
Right, the default label is tricky. I do like I assume esp. with the |
Yeah, I think it would have to add custom JS to switch label for open/closed, which I was trying to avoid. Want to approve and merge what's here now? |
A "universal design" approach to the need for textual facets corresponding to the chart for low-vision or screen-reader-using users.
Putting all the links in a visually-hidden didn't work, becuase you can't actually put focasable things in visually-hidden without problems or more weirdness, so trying this.
Put them on all screens, but inside a collapsible header, to avoid noise for those who don't want them. Went with html5
<details>
after all, does not seem to have any focus nav issues to me.Rearranged some DOM and configuration and made some selectors more flexible in the process.
Still needs i18n on label, and some other cleanup.
There is a lot of info and controls in this panel, it was hard to make it all hopefully clear?