-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RIIIF to 2.0 #1986
Update RIIIF to 2.0 #1986
Conversation
Does the riiif initializer need to change here at all? we have that deprecation warning that something will change in 2.0 |
Ah, there was a typo in that code. Should be fixed now. |
0160a49
to
4c85eeb
Compare
Do you know if there are any breaking changes here we should worry about for our downstream consumers? |
@mejackreed I don't know. I suspect that config change might be it. |
|
Anyone know what's needed to complete this upgrade? |
Can this be rebased? |
@dunn it has been rebased. |
Oop, right now the build is failing because of rubocop. |
dccf57d
to
b11cc7d
Compare
The Rails 5.1/Ruby 2.4 build is consistently failing with:
https://travis-ci.org/projectblacklight/spotlight/jobs/512607508#L3715 |
No description provided.