[BPF] when host IPs change kube-proxy replaces only Syncer #8313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
tomastigera
added
docs-not-required
tomastigera
changed the title
tomastigera
force-pushed
the
tomas-bpf-proxy-healthz
branch
3 times, most recently
from
d70043a to
78500ef
Compare
Restarting the whole proxy is an overkill, only the syncer eed the set of host IPs. Also the health check servers created by kube-proxy frontend are not easily carried over and thus restarting kube-proxy cannot restart the health checks. As a side-effect, the "restart" logic in kube-proxy is much simpler as we do no tneed to stop that much.
tomastigera
force-pushed
the
tomas-bpf-proxy-healthz
branch
from
78500ef to
b95dea0
Compare
3 tasks
tomastigera
added a commit
that referenced
this pull request
Jan 31, 2024
…v3.27 [release-v3.27] Auto pick #8313: when host IP change kube-proxy replaces only Syncer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restarting the whole proxy is an overkill, only the syncer eed the set of host IPs. Also the health check servers created by kube-proxy frontend are not easily carried over and thus restarting kube-proxy cannot restart the health checks.
As a side-effect, the "restart" logic in kube-proxy is much simpler as we do no tneed to stop that much.
fixes #8112
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.