Releasing: Update release process with release archive #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozdanborne
reviewed
Jul 10, 2017
RELEASING.md
Outdated
| 4. Now merge the PR - this will cause the live docs site to be updated (after a few minutes). | ||
| 5. Push the tag. | ||
| 6. Edit the [Calico Docs Custom Search Engine](cse.google.com/). | ||
| `` |
ozdanborne
reviewed
Jul 10, 2017
RELEASING.md
Outdated
| 3. Add a section in `_config.yaml` so that `page.version` will be set correctly in the new subdirectory: | ||
| ```` | ||
| 1. Add a section in `_config.yaml` so that `page.version` will be set correctly in the new subdirectory: | ||
| ``` |
There was a problem hiding this comment.
While you're here, can you indent this entire code block three spaces so it doesn't reset the numbered list?
ozdanborne
reviewed
Jul 10, 2017
RELEASING.md
Outdated
| 1. Move the section for the release in `_data/versions.yaml` to the top of the file so that it will be the 'Latest Release'. | ||
| 1. Run `make add_redirects_for_latest VERSION=vX.Y` to update the redirects. | ||
| 1. Test the changes locally then open a pull request, make sure it passes CI and get it reviewed. | ||
| 1. Create a git tag and docker images by running `make -C calico_node release`. Follow the instructions to push the images but DO NOT PUSH THE TAG YET. |
There was a problem hiding this comment.
This is where the release file is created, right? Can you mention it by saying:
Create a git tag, docker images, and release file by running...
ozdanborne
reviewed
Jul 10, 2017
RELEASING.md
Outdated
| ``` | ||
| 1. Update the `RELEASE_STREAM` variable at the top of calico_node/Makefile to the new major/minor version. | ||
| 1. Test the changes locally then open a pull request, make sure it passes CI and get it reviewed. | ||
| 1. Create a git tag and docker images by running `make -C calico_node release`. Follow the instructions to push the images but DO NOT PUSH THE TAG YET. |
There was a problem hiding this comment.
Same here: Git tag, docker images, and release file
|
Just a couple of wording / clarity nits but other than that, the overall process and jekyll implementation looks good. LGTM after that's addressed. |
Build the release archive as part of make release Update the instructions to say that it should be uploaded Reference the file from the releases page.
|
OK, markups made. Merging. |
caseydavenport
added
the
release-note-required
caseydavenport
pushed a commit
that referenced
this pull request
Dec 14, 2021
…-master [master] Semaphore Auto Pin Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the release archive as part of make release
Update the instructions to say that it should be uploaded
Reference the file from the releases page.
Fixes #893
Release Note