Remove HOSTNAME and IP/IP6 env vars #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robbrockbank is probably best placed to comment on the release note. |
|
Putting this in next-milestone for now, I don't think we need this for v2.4. (but correct me if I'm wrong!) |
|
There is no need for a release note - this is an internal implementation detail. |
| @@ -135,7 +135,7 @@ Enabling IPv6 forwarding | |||
| Increasing conntrack limit | |||
| Running the following command: | |||
|
|
|||
| docker run --net=host --privileged --name=calico-node -d --restart=always -e ETCD_SCHEME=http -e HOSTNAME=calico -e CALICO_LIBNETWORK_ENABLED=true -e ETCD_AUTHORITY=127.0.0.1:2379 -e AS= -e NO_DEFAULT_POOLS= -e ETCD_ENDPOINTS= -e IP= -e IP6= -e CALICO_NETWORKING_BACKEND=bird -v /var/run/docker.sock:/var/run/docker.sock -v /var/run/calico:/var/run/calico -v /lib/modules:/lib/modules -v /var/log/calico:/var/log/calico -v /run/docker/plugins:/run/docker/plugins quay.io/calico/node:{{site.data.versions[page.version].first.title}} | |||
| docker run --net=host --privileged --name=calico-node -d --restart=always -e ETCD_SCHEME=http -e CALICO_LIBNETWORK_ENABLED=true -e ETCD_AUTHORITY=127.0.0.1:2379 -e AS= -e NO_DEFAULT_POOLS= -e ETCD_ENDPOINTS= -e CALICO_NETWORKING_BACKEND=bird -v /var/run/docker.sock:/var/run/docker.sock -v /var/run/calico:/var/run/calico -v /lib/modules:/lib/modules -v /var/log/calico:/var/log/calico -v /run/docker/plugins:/run/docker/plugins quay.io/calico/node:{{site.data.versions[page.version].first.title}} | |||
There was a problem hiding this comment.
This change is unrelated to the issue no?
There was a problem hiding this comment.
yeah, not directly related to this PR. will remove and respin the PR.
|
I don't think the issue requires the node run documentation to be updated does it, or is that addressing a different issue? |
HOSTNAME has been replaced by NODENAME and IP/IP6 now come from the Node resource, as part of projectcalico/calicoctl#1453. See issue: projectcalico/calico-bgp-daemon#18
|
LGTM |
robbrockbank
approved these changes
Jul 18, 2017
caseydavenport
pushed a commit
that referenced
this pull request
Dec 14, 2021
…-master [master] Semaphore Auto Pin Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No longer set HOSTNAME or IP/IP6 environment variables because they've been replaced by NODENAME and Node resource, respectively.
I don't see a release note mentioning this change. @caseydavenport , can you confirm?
Todos
Release Note