Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry pick] [release tool] Allow building and publishing image in hashrelease #9534

Open
wants to merge 5 commits into
base: release-v3.29
Choose a base branch
from

Conversation

radTuti
Copy link
Contributor

@radTuti radTuti commented Nov 26, 2024

Description

This take in 4 commits from master to allow this

  • c6bca4b: moved the definition of OPERATOR_BRANCH from hashrelease semaphore file w/ update for the correct operator branch for this branch
  • 7acfd45: main PR for this change in master branch
  • ab3dd94 & f47ecf7 & 240c89f: variable fixes to main PR

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

caseydavenport and others added 4 commits November 26, 2024 15:12
…ashrelease (projectcalico#9429)

* update cleaning old hashreleases

* Allow building and publishing images in hashrelease

* fix building images for hashrelease

- key-cert-provisioner: add release-build and release-publish targets
- add ability to skip release notes

* address review feedback

* fix publishing images for hashrelease

- add custom registry to pinnedversion
- allowing skipping validation for publish
- fail if hashrelease latest is set while using custom registry
- move hashrelease validation to calico manager
- update .gitignore to ignore publishing identifier files
- fix key-cert-provisioner publishing

* update publish prereqs

- check hashrelease server config if publishHashrelease == true
- move release-verify from Makefile to golang tool

* merge format fix

* utilize operator optimization

* remove Registry in pinnedversion

* release notes uses projectcalico org

* update hashrelease pipeline

* address review comments
@radTuti radTuti added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Nov 26, 2024
@radTuti radTuti requested a review from a team November 26, 2024 23:17
@radTuti radTuti requested a review from a team as a code owner November 26, 2024 23:17
@marvin-tigera marvin-tigera added this to the Calico v3.29.2 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants