[release-tool] refactor update branch command and manager #9616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radTuti
added
docs-not-required
| return re.MatchString(string(v)) | ||
| } | ||
|
|
||
| // DetermineReleaseVersion uses historical clues to figure out the next semver | ||
| // release number to use for this release based on the current git revision. | ||
| // | ||
| // OSS Calico uses the following rules: |
There was a problem hiding this comment.
I think there is value in separating the version rules that OSS uses vs enterprise?
There was a problem hiding this comment.
At the moment, the way the rules are structured apply with OSS and Enterprise although Enterprise is only the first scenario since it creates a new dev tag after every release.
radTuti
force-pushed
the
reltool-branch
branch
from
2f61f31 to
cd991e3
Compare
radTuti
force-pushed
the
reltool-branch
branch
from
cd991e3 to
94b1b26
Compare
caseydavenport
approved these changes
Dec 20, 2024
radTuti
added a commit
to radTuti/calico
that referenced
this pull request
Dec 20, 2024
…ico#9616) * update branching and versioning * address review feedback
3 tasks
radTuti
added a commit
to radTuti/calico
that referenced
this pull request
Dec 31, 2024
…ico#9616) * update branching and versioning * address review feedback
radTuti
added a commit
to radTuti/calico
that referenced
this pull request
Jan 3, 2025
…ico#9616) * update branching and versioning * address review feedback
radTuti
added a commit
to radTuti/calico
that referenced
this pull request
Jan 9, 2025
…ico#9616) * update branching and versioning * address review feedback
coutinhop
pushed a commit
that referenced
this pull request
Jan 9, 2025
* [release tool] restructure: main.go (#9565) * rename release/build to release/cmd build was a folder name for using goyek; cmd is the proper way * resturture main.go - create Command interface to return subcommands - move each subcommand to separate file - create flags.go to house all flags * fix release build * Apply suggestions from code review Co-authored-by: Casey Davenport <caseydavenport@users.noreply.github.com> * move cmd definitions to own files --------- Co-authored-by: Casey Davenport <caseydavenport@users.noreply.github.com> * [release tool] remove config package (#9578) * switch to flags instead of using config package * clean ups - minimize hardcoded strings - reduce info logs - created shared.go for fns used across commands * trim fat and address review feedback * keep repoRoot as internal config * [release tool] refactor pinnedversion (#9595) * refactor pinnedversion ref: DE-2970 * address review * [release tool] pass in GitHub token as flag for actual release (#9596) * pass in GitHub token as flag for actual release * CI fix * [release-tool] refactor update branch command and manager (#9616) * update branching and versioning * address review feedback * [release tool] refactor generating hashrelease and release (#9634) * refactor generating hashrelease and release * CI fix * cleanup - remove copying pinned version to hashrelease dir - removed hard-coded string - simplify code generation * minor fix * address review * [release tool] fix hashrelease failure (#9661) * fix checking if hashrelease already exists * split hashrelease commands * address review feedback * Load value from metadata.mk in release tool (#9659) * fix hashrelease local src directory (#9673) * [release tool] fix hashrelease hanging on image checks (#9681) * rewrite image check with timeout * pass components list to manager * cleanup * address review feedback --------- Co-authored-by: Casey Davenport <caseydavenport@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update the
branchsubcommands and branch manager.As an extension, version package is also updated to support EPs and allow avoiding conflicts in closed source.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.