Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertise LoadBalancer IPs #422

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Advertise LoadBalancer IPs #422

merged 3 commits into from
Jan 5, 2021

Conversation

caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Dec 29, 2020 •
edited
Loading

Thanks to @salanki for starting this work here: #385

This works much the same as our ClusterIP / ExternalIP advertisement.

  • Advertise each range provided in the BGP configuration from every node.
  • Advertise LoadBalancer IP addresses for services with externalTrafficPolicy: Local from nodes with local endpoints.
  • Only advertise those IPs if they are within a configured range on the BGP config.
Ability to advertise LoadBalancer IPs over BGP

@marvin-tigera marvin-tigera added this to the Calico v3.18.0 milestone Dec 29, 2020
@caseydavenport caseydavenport mentioned this pull request Dec 29, 2020
Closed
@caseydavenport caseydavenport mentioned this pull request Dec 31, 2020
Merged
3 tasks
nelljerram
nelljerram approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@nelljerram nelljerram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caseydavenport caseydavenport merged commit 0dcdd2c into projectcalico:master Jan 5, 2021
@caseydavenport caseydavenport deleted the casey-advertise-lb branch January 5, 2021 19:08
@caseydavenport caseydavenport mentioned this pull request Jan 5, 2021
Closed
@0HFgX1pM8hUbvsCpAl3D
Copy link

Is there documentation on how to implement this? I was able to get metallb to hand out an IP address but Calico isn't sending it to my router.

@caseydavenport
Copy link
Member Author

This is probably what you're looking for: https://docs.tigera.io/calico/latest/networking/configuring/advertise-service-ips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelljerram nelljerram nelljerram approved these changes

Assignees
No one assigned
Labels
docs-completed release-note-required
Projects
None yet
Milestone
Calico v3.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@caseydavenport @0HFgX1pM8hUbvsCpAl3D @nelljerram @marvin-tigera @salanki