Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph*-3.0): only accepts integer or string as id #1009

Merged
merged 1 commit into from
Apr 7, 2020
Merged

fix(graph*-3.0): only accepts integer or string as id #1009

merged 1 commit into from
Apr 7, 2020

Conversation

rhizoome
Copy link

@rhizoome rhizoome commented Apr 2, 2020

#814 creates a lot of chicken and egg problems. I want to at least push simple fixes to caluma.

The graph*-3.0 projects try to validate all inputs and prevent all implicit conversion.

@rhizoome rhizoome requested review from JohnL17 and removed request for JohnL17 April 2, 2020 14:41
@rhizoome rhizoome changed the title fix(graph*-3.0): will only accept integer or string as id fix(graph*-3.0): only accept integer or string as id Apr 2, 2020
@rhizoome rhizoome requested review from JohnL17 and winged April 2, 2020 14:58
@rhizoome rhizoome changed the title fix(graph*-3.0): only accept integer or string as id fix(graph*-3.0): only accepts integer or string as id Apr 2, 2020
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is this the only place where this specific pattern occurs?

@winged winged merged commit d186c27 into projectcaluma:master Apr 7, 2020
@rhizoome
Copy link
Author

rhizoome commented Apr 7, 2020

@winged There are many places, but I fix bugs in order. Of the 20 bugfixes I have in my branch, only this one had no connections to other problems and could be cleanly pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants