Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emeisOptions)!: component injection via emeisOptions #431

Merged

Conversation

derrabauke
Copy link
Contributor

BREAKING CHANGE: replaces customButton with customComponent property in emeisOptions service

@derrabauke derrabauke requested a review from czosel March 1, 2022 13:17
README.md Outdated Show resolved Hide resolved
BREAKING CHANGE: replaces customButton with customComponent property in emeisOptions service
@derrabauke derrabauke force-pushed the feat-component-injection-emeis-options branch from f60b291 to 15906b9 Compare March 2, 2022 16:53
Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@czosel czosel merged commit a293ea8 into projectcaluma:main Mar 4, 2022
github-actions bot pushed a commit that referenced this pull request Mar 4, 2022
# [5.0.0](v4.2.1...v5.0.0) (2022-03-04)

* feat(emeisOptions)!: component injection via emeisOptions (#431) ([a293ea8](a293ea8)), closes [#431](#431)

### BREAKING CHANGES

* replaces customButton with customComponent property in emeisOptions service
@czosel
Copy link
Contributor

czosel commented Mar 4, 2022

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@czosel czosel added the released label Mar 4, 2022
derrabauke added a commit to derrabauke/ember-emeis that referenced this pull request Apr 14, 2022
…uma#431)

BREAKING CHANGE: replaces customButton with customComponent property in emeisOptions service
derrabauke pushed a commit to derrabauke/ember-emeis that referenced this pull request Apr 14, 2022
# [5.0.0](projectcaluma/ember-emeis@v4.2.1...v5.0.0) (2022-03-04)

* feat(emeisOptions)!: component injection via emeisOptions (projectcaluma#431) ([a293ea8](projectcaluma@a293ea8)), closes [projectcaluma#431](projectcaluma#431)

### BREAKING CHANGES

* replaces customButton with customComponent property in emeisOptions service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants