Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserving externally managed labels #986

Merged
merged 1 commit into from
Feb 18, 2024
Merged

fix: preserving externally managed labels #986

merged 1 commit into from
Feb 18, 2024

Conversation

prometherion
Copy link
Member

Closes #985.

@prometherion
fix: preserving externally managed labels
50ecc8a 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2024 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 50ecc8a
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/65d1fe3fb62e7400089ecef4

@prometherion
Copy link
Member Author

@oliverbaehler this is a prerequisite for projectcapsule/capsule-proxy#303 projectcapsule/capsule-proxy#185

oliverbaehler
oliverbaehler approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@oliverbaehler oliverbaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add e2e test to ensure this behavior?

@prometherion
Copy link
Member Author

We should, I'll try to work on this with a different PR.

@prometherion prometherion merged commit 65a7439 into projectcapsule:main Feb 18, 2024
21 of 22 checks passed
@prometherion prometherion deleted the issues/985 branch February 18, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverbaehler oliverbaehler oliverbaehler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkPolicy, LimitRange, and ResourceQuota objects labels are overwritten
2 participants
@prometherion @oliverbaehler