Skip to content

Update MemoryFence definition logic #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Update MemoryFence definition logic #13

merged 1 commit into from
Nov 28, 2023

Conversation

AjanZhong
Copy link

@AjanZhong AjanZhong commented Nov 23, 2023

Both nvme and virtual_media driver invokes MemoryFence function,
implement inline function in corresponding header files as inline
function to avoid multi definition link issue.

Also provide MemoryFence symbol in libefiwrapper for kernelflinger
to link MemoryFence symbol which supposed to be implemented in EFI
componment.

Tracked-On: OAM-113553

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:Update Bugs And Epics Update Bugs And Epics

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1060

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:Update Bugs And Epics Update Bugs And Epics

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1062

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckBug Bad comments/Bugs

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1075

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:Trigger Builds Triggered: build-cels - r1 (celadon_ivi), build-cels - r2 (r2_apollo_ivi), build-cels - r2 (r2_blizzard_ivi) - extra, build-cels - r2 (r2_celadon_ivi), build-cels - r2 (r2_everest_ivi)

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1076

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@AjanZhong AjanZhong changed the title Update MemoryFence for virtual_media driver Update MemoryFence definition logic Nov 27, 2023
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

1 similar comment
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

1 similar comment
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

Verified

This commit was signed with the committer’s verified signature.
refack Refael Ackermann
Both nvme and virtual_media driver invokes MemoryFence function,
implement inline function in corresponding header files as inline
function to avoid multi definition link issue.

Also provide MemoryFence symbol in libefiwrapper for kernelflinger
to link MemoryFence symbol which supposed to be implemented in EFI
componment.

Tracked-On: OAM-113553
Signed-off-by: Zhong,Fangjian <fangjian.zhong@intel.com>
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckBug Bad comments/Bugs

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1088

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'preintegration' builder

More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/1089

Done by "Zhong, Fangjian" fangjian.zhong@intel.com

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'premerge' builder

More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/587

Done by "Zhong, Fangjian" fangjian.zhong@intel.com

@sysopenci sysopenci merged commit bdd4f65 into projectceladon:celadon/s/mr0/master Nov 28, 2023
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cactus finished building and testing your changes

It was requested for merge by "Zhong, Fangjian" fangjian.zhong@intel.com

so we merge it. Thanks for your contribution.

more details, logs, and binaries: /absp/builders/celadon_smr0_master-mergerequest/builds/606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants