Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
  • Loading branch information
sunjayBhatia committed May 7, 2024
1 parent 5112a92 commit 23a1bb4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion changelogs/unreleased/6269-sunjayBhatia-minor.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## Update examples for monitoring Contour and Envoy

Updates the documentation and examples for deploying a monitoring stack (Prometheus and Grafana) to scrape metrics from Contour and Envoy.
Updates the [documentation](https://projectcontour.io/docs/main/guides/prometheus/) and examples for deploying a monitoring stack (Prometheus and Grafana) to scrape metrics from Contour and Envoy.
Adds a metrics port to the Envoy DaemonSet/Deployment in the example YAMLs to expose port `8002` so that `PodMonitor` resources can be used to find metrics endpoints.
4 changes: 0 additions & 4 deletions site/content/docs/main/guides/prometheus.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ title: Collecting Metrics with Prometheus

<div id="toc" class="navigation"></div>

Contour and Envoy expose metrics that can be scraped with Prometheus. By
default, annotations to gather them are in all the `deployment` yamls and they
should work out of the box with most configurations.

## Envoy Metrics

Envoy typically [exposes metrics](https://www.envoyproxy.io/docs/envoy/v1.15.0/configuration/http/http_conn_man/stats#config-http-conn-man-stats) through an endpoint on its admin interface. To
Expand Down

0 comments on commit 23a1bb4

Please sign in to comment.