-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a /healthz style probe #10
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
Milestone
Comments
davecheney
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Oct 31, 2017
davecheney
added a commit
to davecheney/contour
that referenced
this issue
Jan 29, 2018
Fixes projectcontour#86 Updates projectcontour#10 This PR adds healthz support to contour using the heptiolabs/healthcheck library. The envoy container's heathcheck is not done, yet. Signed-off-by: Dave Cheney <dave@cheney.net>
Closed
sunjayBhatia
pushed a commit
that referenced
this issue
Jan 30, 2023
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Contour should be defining probes so that traffic isn't sent to an instance until it is ready. Similarly, this should support a more graceful drain mechanism when downscaling.
The way I thought about doing this was injecting a default vhost into Envoy pointing to Contour that would provide a /healthz endpoint. The idea being that until both Envoy and Contour were up; hitting the node via IP or internal host name (as the ELB does) would not return healthy until both processes were running.
The text was updated successfully, but these errors were encountered: