Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: Envoy use Contour dns name for gRPC connection #1127

Closed
stevesloka opened this issue May 28, 2019 · 4 comments · Fixed by #1203
Closed

deployment: Envoy use Contour dns name for gRPC connection #1127

stevesloka opened this issue May 28, 2019 · 4 comments · Fixed by #1203
Assignees
Milestone

Comments

@stevesloka
Copy link
Member

Describe the solution you'd like
Updating #1122, in the split deployment model, Envoy utilizes the built-in service environment variables (https://github.com/heptio/contour/blob/master/deployment/ds-hostnet-split/03-envoy.yaml#L67 && https://github.com/heptio/contour/blob/master/deployment/ds-hostnet-split/03-envoy.yaml#L69).

If the deployment or daemonset is created before the service exists, then these variables won't exist.

We should look to have Envoy use the internal dns name of contour instead of the env variable. Last time I attempted this I ran into Envoy issues resolving that name properly.

Also, if we switch to this model, the port cannot be automatically determined. Users will need to keep those numbers in sync (just noting so we can document properly).

@davecheney
Copy link
Contributor

@stevesloka thanks for looking at this. Do you want to tackle this for 0.13, or punt til 0.14? Could you have a think about the best time to tackle this and label/milestone accordingly. Thanks

@stevesloka stevesloka added this to the 0.14.0 milestone May 31, 2019
@stevesloka
Copy link
Member Author

@davecheney this can be a 0.14.0 issue, it's not a critical block at the moment, but we should address soon so it doesn't affect other users.

@davecheney
Copy link
Contributor

davecheney commented Jun 1, 2019 via email

@youngnick youngnick self-assigned this Jun 28, 2019
@youngnick
Copy link
Member

Picking up this one to work on in tandem with #862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants