Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update split deployments with TLS secured gRPC #1203

Merged
merged 3 commits into from
Jul 4, 2019

Conversation

youngnick
Copy link
Member

@youngnick youngnick commented Jul 1, 2019

Fixes #862
Updates #881

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the secret type use kubernetes.io/tls instead of generic? This way we could have the cert/key's be consistent inside the secret which makes users generating their own a bit easier.

@davecheney
Copy link
Contributor

davecheney commented Jul 3, 2019 via email

@youngnick
Copy link
Member Author

Should the secret type use kubernetes.io/tls instead of generic? This way we could have the cert/key's be consistent inside the secret which makes users generating their own a bit easier.

TIL about that type of secret. I'll get right on that, then merge.

Nick Young added 3 commits July 4, 2019 10:41
- Add `make gencerts` and `make applycerts` to Makefile
- Update `ds-hostnet-split` to expect the new certs.

Signed-off-by: Nick Young <ynick@vmware.com>
Signed-off-by: Nick Young <ynick@vmware.com>
Signed-off-by: Nick Young <ynick@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deployment: Envoy use Contour dns name for gRPC connection Encrypt gRPC traffic between Contour and Envoy
3 participants