Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard host for ingress #13

Closed
rusenask opened this issue Oct 31, 2017 · 9 comments
Closed

Wildcard host for ingress #13

rusenask opened this issue Oct 31, 2017 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@rusenask
Copy link

Hello,

I have a use case where I need multiple hostnames routed to the same backend service, example:

http://foo.webrelay.io -> relayServiceName:9400
http://bar.webrelay.io -> relayServiceName:9400

https://foobar.webrelay.io -> relayServiceName:9500
https://foobarfoo.webrelay.io -> relayServiceName:9500

This list could be expanded and contracted dynamically, therefore wildcard hostnames would be great. Ingress example:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: relay-ingress
spec:
  rules:
  - host: '*.webrelay.io'
    http:
      paths:
      - backend:
          serviceName: whr
          servicePort: 9400
        path: /
@davecheney
Copy link
Contributor

Thanks for raising this issue, as long as this is supported by the ingress spec, this doesn't look to hard to implement.

I'm tentitively scheduling this for 0.2

@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 31, 2017
@davecheney davecheney added this to the 0.2.0 milestone Oct 31, 2017
@davecheney davecheney modified the milestones: 0.2.0, 0.3.0 Nov 27, 2017
@davecheney
Copy link
Contributor

davecheney commented Nov 27, 2017

I'm going to bump this to 0.3.

The issue is the ingress spec does not permit '*'. Various ingress implementations maybe permit it either as an extension, or just dumb luck, but I want to think carefully about what interpretation contour would make when this field is not a RFC 3986 compliant URI. We may choose to extend the interpretation to follow what the Nginx ingress does, but this isn't something I'm going to jump into as it will be near impossible to return that genie to the bottle.

@davecheney
Copy link
Contributor

Bumping to 0.4

@davecheney davecheney modified the milestones: 0.3.0, 0.4.0 Jan 12, 2018
@mykter
Copy link

mykter commented Jan 24, 2018

Just arrived via the "good first issue" label - reading the November comment that perhaps is no longer an accurate label.

@DylanGraham
Copy link
Contributor

DylanGraham commented Mar 1, 2018

Since DNS providers generally allow wildcards which you can point to your loadbalancer, would this be best left to having host names explicitly listed in the Ingress?

The ingress docs also mention that having no hostname defaults to * so maybe this, combined with a DNS wildcard would solve your use case?

@davecheney davecheney removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 1, 2018
@davecheney
Copy link
Contributor

This one is tricky, I've removed the good first issue tag

@davecheney
Copy link
Contributor

@DylanGraham I agree with this. You could use the default ingress to accomplish this as a workaround, but that would mean you could only do this once per instance of contour which isn't ideal.

@davecheney
Copy link
Contributor

I'm going to remove the 0.4 milestone for this. I'm not sure what the best way to approach this is; the 1.9 api docs for ingress say that the host: field must be Host is the fully qualified domain name of a network host, as defined by RFC 3986, which excludes meta characters like *.

@davecheney davecheney removed this from the 0.4.0 milestone Mar 13, 2018
@davecheney
Copy link
Contributor

Duplicate of #1228

@davecheney davecheney marked this as a duplicate of #1228 Sep 29, 2019
lrouquette pushed a commit to lrouquette/contour that referenced this issue Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants