Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON logging should report invalid headers #1507

Closed
youngnick opened this issue Sep 16, 2019 · 0 comments · Fixed by #3059
Closed

JSON logging should report invalid headers #1507

youngnick opened this issue Sep 16, 2019 · 0 comments · Fixed by #3059
Labels
kind/feature Categorizes issue or PR as related to a new feature. known-issue Known issues for release notes
Milestone
Backlog

Comments

@youngnick
Copy link
Member

The current implementation of JSON logging silently discards invalid headers. Invalid headers should be surfaced to the user, probably at startup.

(see internal/contour/accesslog.go to get started).
@youngnick youngnick added this to the Backlog milestone Sep 16, 2019
@youngnick youngnick added kind/feature Categorizes issue or PR as related to a new feature. known-issue Known issues for release notes labels Sep 16, 2019
@jpeach jpeach mentioned this issue Oct 18, 2020
Closed
mike1808 added a commit to cf-routing/contour that referenced this issue Oct 23, 2020
@mike1808
internal/envoy: send custom JSON fields to Envoy
9ee5aec 
Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Clay Kauzlaric <ckauzlaric@vmware.com>
mike1808 added a commit to cf-routing/contour that referenced this issue Oct 23, 2020
@mike1808 @KauzClay
internal/envoy: send custom JSON fields to Envoy
b1b8f4c 
Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Mikael Manukyan <mmanukyan@vmware.com>
mike1808 added a commit to cf-routing/contour that referenced this issue Oct 23, 2020
@mike1808
internal/envoy: send custom JSON fields to Envoy
6cf13f1 
Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Mikael Manukyan <mmanukyan@vmware.com>
mike1808 added a commit to cf-routing/contour that referenced this issue Oct 23, 2020
@mike1808 @KauzClay
internal/envoy: send custom JSON fields to Envoy
c007f5c 
Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
@mike1808 mike1808 mentioned this issue Oct 23, 2020
Merged
XanderStrike pushed a commit to cf-routing/contour that referenced this issue Oct 26, 2020
@mike1808 @KauzClay
internal/envoy: send custom JSON fields to Envoy
19a8fbb 
Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Alexander Standke <astandke@vmware.com>
XanderStrike pushed a commit to cf-routing/contour that referenced this issue Oct 27, 2020
@KauzClay @mike1808
pkg/config, pkg/internal: support custom Envoy JSON fields
637993b 
Add support for custon Envoy JSON fields via use of `=` in the field
name.

See [design doc](design/envoy-json-logging-custom-fields-design.md) for
more information.

Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Mikael Manukyan <mmanukyan@vmware.com>
Co-authored-by: Mikael Manukyan <mmanukyan@vmware.com>
Co-authored-by: Alexander Standke <astandke@vmware.com>
XanderStrike pushed a commit to cf-routing/contour that referenced this issue Oct 27, 2020
@mike1808 @KauzClay
pkg/config, pkg/internal: support custom Envoy JSON fields
4261478 
Add support for custon Envoy JSON fields via use of `=` in the field
name.

See [design doc](design/envoy-json-logging-custom-fields-design.md) for
more information.

Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Mikael Manukyan <mmanukyan@vmware.com>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Alexander Standke <astandke@vmware.com>
XanderStrike pushed a commit to cf-routing/contour that referenced this issue Oct 27, 2020
@mike1808 @KauzClay
pkg/config, pkg/internal: support custom Envoy JSON fields
2cadfa7 
Add support for custon Envoy JSON fields via use of `=` in the field
name.

See [design doc](design/envoy-json-logging-custom-fields-design.md) for
more information.

Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Mikael Manukyan <mmanukyan@vmware.com>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Alexander Standke <astandke@vmware.com>
XanderStrike pushed a commit to cf-routing/contour that referenced this issue Oct 27, 2020
@mike1808 @KauzClay
pkg/config, pkg/internal: support custom Envoy JSON fields
190c669 
Add support for custon Envoy JSON fields via use of `=` in the field
name.

See [design doc](design/envoy-json-logging-custom-fields-design.md) for
more information.

Fixes projectcontour#3032, projectcontour#1507

Signed-off-by: Mikael Manukyan <mmanukyan@vmware.com>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Alexander Standke <astandke@vmware.com>
jpeach pushed a commit that referenced this issue Oct 27, 2020
@mike1808 @KauzClay
pkg/config, pkg/internal: support custom Envoy JSON fields (#3059)
93d3016 
Add support for custon Envoy JSON fields via use of `=` in the field
name.

See [design doc](design/envoy-json-logging-custom-fields-design.md) for
more information.

Fixes #3032, #1507

Signed-off-by: Mikael Manukyan <mmanukyan@vmware.com>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Alexander Standke <astandke@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. known-issue Known issues for release notes
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add support for custom Envoy JSON fields cf-routing/contour
1 participant
@youngnick