Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header.Contains tests lack tests #1880

Closed
davecheney opened this issue Nov 11, 2019 · 3 comments
Closed

Header.Contains tests lack tests #1880

davecheney opened this issue Nov 11, 2019 · 3 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@davecheney
Copy link
Contributor

Header Contains conditions that result in a regex matcher are not tested. Tests at the internal/contour and internal/featuretest level should be added.
@davecheney davecheney added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 11, 2019
@davecheney davecheney added this to the 1.1.0 milestone Nov 11, 2019
davecheney added a commit to davecheney/contour that referenced this issue Nov 11, 2019
@davecheney
internal/envoy: switch HeaderMatch to SafeRegex
d28e5f9 
Updates projectcontour#1351

nb. there appear to be no internal/contour, internal/e2e, or
internal/featuretest tests for header contains matching. I've raised
 projectcontour#1880 to track this.

Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney davecheney mentioned this issue Nov 11, 2019
Merged
jpeach pushed a commit that referenced this issue Nov 15, 2019
@davecheney @jpeach
internal/envoy: switch HeaderMatch to SafeRegex
01e9811 
Updates #1351

nb. there appear to be no internal/contour, internal/e2e, or
internal/featuretest tests for header contains matching. I've raised
 #1880 to track this.

Signed-off-by: Dave Cheney <dave@cheney.net>
@stevesloka stevesloka self-assigned this Dec 3, 2019
@stevesloka
Copy link
Member

@davecheney there isn't any logic in internal/contour for regex other than sorting them. There are tests in internal/envoy where the regex is applied. What were your thoughts for tests inside internal/contour?

@stevesloka stevesloka mentioned this issue Dec 6, 2019
Merged
@davecheney davecheney modified the milestones: 1.1.0, Backlog Dec 13, 2019
@stevesloka stevesloka removed their assignment Jan 21, 2020
@skriss skriss removed this from the Backlog milestone Jul 25, 2022
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2024
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davecheney @stevesloka @skriss