Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration support to tune or disable listener Keepalives. #2652

Open
jpeach opened this issue Jul 5, 2020 · 4 comments
Open

Add configuration support to tune or disable listener Keepalives. #2652

jpeach opened this issue Jul 5, 2020 · 4 comments
Labels
area/deployment Issues or PRs related to deployment tooling or infrastructure. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid.

Comments

@jpeach
Copy link
Contributor

jpeach commented Jul 5, 2020

Please describe the problem you have

Followup from #2638 #2633

If the Envoy proxy that Contour is programming isn't running on Linux, it will NACK the listener update, and Contour won't know how to recover from that. In this case, an operator would need a way to disable setting Linux-specific socket options.

There may be use cases for tweaking the Listener keep alive tunables. We can collect implementation experience here.
@jpeach jpeach added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/deployment Issues or PRs related to deployment tooling or infrastructure. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid. labels Jul 5, 2020
@jpeach
Copy link
Contributor Author

jpeach commented Jul 5, 2020

xref #2543

@erwbgy
Copy link
Contributor

erwbgy commented Jul 8, 2020

@jpeach on #2638 you said "I don't know of any use case for supporting Envoy on non-Linux" and I agree. Until such a use case exists can we not just update https://projectcontour.io/resources/envoy/ to say that we only support running Envoy on Linux?

@jpeach
Copy link
Contributor Author

jpeach commented Jul 8, 2020

@jpeach on #2638 you said "I don't know of any use case for supporting Envoy on non-Linux" and I agree. Until such a use case exists can we not just update https://projectcontour.io/resources/envoy/ to say that we only support running Envoy on Linux?

Yeh, though the corollary of that is that it's probably fine to have an emergency knob rather than implementing this for various platform.

@youngnick youngnick mentioned this issue Dec 17, 2020
Closed
binoue added a commit to binoue/contour that referenced this issue Dec 31, 2020
@binoue
internal/envoy/v3/bootstrap: Make configurble about keepalive settings
4ddbc92 
This change allows users to tune envoy's keepalive settings.

Fixes projectcontour#2652
Fixes projectcontour#3214

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
binoue added a commit to binoue/contour that referenced this issue Dec 31, 2020
@binoue
internal/envoy/v3/bootstrap: Make configurble about keepalive settings
d4ad425 
This change allows users to tune envoy's keepalive settings.

Fixes projectcontour#2652
Fixes projectcontour#3214

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
binoue added a commit to binoue/contour that referenced this issue Dec 31, 2020
@binoue
internal/envoy/v3/bootstrap: Make configurble about envoy keepalive s…
cf9a737 
…ettings

This change allows users to tune envoy's keepalive settings.

Fixes projectcontour#2652
Fixes projectcontour#3214

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
binoue added a commit to binoue/contour that referenced this issue Dec 31, 2020
@binoue
internal/envoy/v3/bootstrap: Make configurable about keepalive settings.
c6c378e 
This change allows users to tune envoy's keepalive settings.

Fixes projectcontour#2652
Fixes projectcontour#3214

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
@binoue binoue mentioned this issue Dec 31, 2020
Closed
@sunjayBhatia
Copy link
Member

As we may be moving to support Envoy/Contour running on Windows, this cross-platform issue will come up again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/deployment Issues or PRs related to deployment tooling or infrastructure. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal/envoy/v3/bootstrap: Make configurable about keepalive settings. binoue/contour
3 participants
@jpeach @erwbgy @sunjayBhatia