Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run Gateway API conformance tests as part of CI #4429

Closed
skriss opened this issue Mar 30, 2022 · 2 comments · Fixed by #4452
Closed

run Gateway API conformance tests as part of CI #4429

skriss opened this issue Mar 30, 2022 · 2 comments · Fixed by #4452
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. area/testing Issues or PRs related to tests or testing tools.
Milestone
1.21.0

Comments

@skriss
Copy link
Member

skriss commented Mar 30, 2022

At some point we should start running the Gateway API conformance tests as part of our CI, either for all builds or on a nightly basis. Right now, with the use of the provisioner and kubernetes-sigs/gateway-api#1080, we're passing everything. We'd probably want to make it non-blocking if we run it for PRs, since as more tests get added to the suite we're bound to find existing gaps/bugs in our implementation.
@skriss skriss added kind/feature Categorizes issue or PR as related to a new feature. area/testing Issues or PRs related to tests or testing tools. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Mar 30, 2022
@skriss skriss self-assigned this Mar 30, 2022
@xaleeks
Copy link

xaleeks commented Apr 4, 2022

can we add this to 1.21? @skriss

@skriss
Copy link
Member Author

skriss commented Apr 4, 2022

Yeah we should be able to, just waiting for one upstream PR to merge first.

@skriss skriss added this to the 1.21.0 milestone Apr 4, 2022
@skriss skriss removed lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 4, 2022
skriss added a commit to skriss/contour that referenced this issue Apr 6, 2022
@skriss
ci: run Gateway API conformance tests
43e0d52 
Closes projectcontour#4429.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Apr 6, 2022
Merged
skriss added a commit that referenced this issue Apr 6, 2022
@skriss
CI: run Gateway API conformance tests (#4452)
eb6cae4 
Closes #4429.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. area/testing Issues or PRs related to tests or testing tools.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging a pull request may close this issue.

ci: run Gateway API conformance tests skriss/contour
2 participants
@skriss @xaleeks