Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: set supported version condition on GatewayClass #5754

Closed
skriss opened this issue Sep 14, 2023 · 1 comment · Fixed by #6147
Closed

Gateway API: set supported version condition on GatewayClass #5754

skriss opened this issue Sep 14, 2023 · 1 comment · Fixed by #6147
Assignees
@sunjayBhatia
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.28.0

Comments

@skriss
Copy link
Member

skriss commented Sep 14, 2023

ref. kubernetes-sigs/gateway-api#2384
@skriss skriss added kind/feature Categorizes issue or PR as related to a new feature. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. labels Sep 14, 2023
@skriss skriss added this to the 1.27.0 milestone Sep 14, 2023
@skriss skriss added this to Contour Sep 14, 2023
@skriss skriss moved this to Todo in Contour Sep 14, 2023
@skriss skriss added the blocked/needs-gateway-api Categorizes the issue or PR as blocked because it needs changes in Gateway API. label Oct 9, 2023
@skriss skriss modified the milestones: 1.27.0, 1.28.0 Oct 9, 2023
@skriss skriss removed the blocked/needs-gateway-api Categorizes the issue or PR as blocked because it needs changes in Gateway API. label Nov 2, 2023
@sunjayBhatia
Copy link
Member

Todos here:

  • add RBAC for and fetch gatewayclasses.gateway.networking.k8s.io CustomResourceDefinition
    • on provisioner startup? or maybe better on each GatewayClass reconcile loop so if the CRDs are changed, we can find that out?
  • if resource has gateway.networking.k8s.io/bundle-version annotation value that is not supported, then add status condition SupportedVersion: False with appropriate reason/message (otherwise True)
  • make a decision on what versions are supported
    • do we support version skew?
    • if so, need to test multiple versions of the CRDs
    • what happens if CRD bundle version is updated to an unsupported version?

@sunjayBhatia sunjayBhatia mentioned this issue Jan 30, 2024
Merged
@sunjayBhatia sunjayBhatia self-assigned this Jan 30, 2024
@sunjayBhatia sunjayBhatia moved this from Todo to In Progress in Contour Jan 30, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Contour Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunjayBhatia sunjayBhatia

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Contour
Status: Done
Milestone
1.28.0
Development

Successfully merging a pull request may close this issue.

provisioner: Set SupportedVersion condition on GatewayClass sunjayBhatia/contour
2 participants
@skriss @sunjayBhatia