provisioner: Set SupportedVersion condition on GatewayClass #6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Gateway API CRD bundle-version annotation We will still reconcile the GatewayClass etc. but will set a status condition on the GatewayClass saying this support is best effort. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
added
the
release-note/small
sunjayBhatia
requested review from
tsaarni,
skriss,
a team,
izturn and
clayton-gonsalves
and removed request for
a team
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6147 +/- ##
==========================================
- Coverage 78.81% 78.57% -0.24%
==========================================
Files 138 140 +2
Lines 19790 19952 +162
==========================================
+ Hits 15597 15677 +80
- Misses 3884 3966 +82
Partials 309 309
|
sunjayBhatia
commented
Jan 30, 2024
sunjayBhatia
commented
Jan 30, 2024
izturn
reviewed
Jan 31, 2024
skriss
reviewed
Jan 31, 2024
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
skriss
approved these changes
Jan 31, 2024
|
@sunjayBhatia PTAL at kubernetes-sigs/gateway-api#3368 which intends to add a SupportedVersion conformance test. The PR has triggered a discussion regarding the relevancy of this feature. When you have a moment, can you comment in the related discussion to help the Gateway API community better understand your use case of this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Gateway API CRD bundle-version annotation
We will still reconcile the GatewayClass etc. but will set a status condition on the GatewayClass saying this support is best effort.
Fixes #5754