Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop Contour config file's gateway.controllerName option #5923

Closed
skriss opened this issue Oct 31, 2023 · 1 comment · Fixed by #6145
Closed

drop Contour config file's gateway.controllerName option #5923

skriss opened this issue Oct 31, 2023 · 1 comment · Fixed by #6145
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation.
Milestone
1.29.0

Comments

@skriss
Copy link
Member

skriss commented Oct 31, 2023

In the original Gateway API implementation in Contour, the Contour controller was able to be configured with a Gateway controller name. It would then find the oldest GatewayClass for that controller, and the oldest Gateway for that GatewayClass, and process routes for it.

Subsequently, we've introduced the Gateway provisioner, which watches for/processes all GatewayClasses and associated Gateways for a given controller name, and enabled the Contour controller to be configured with a specific Gateway namespace/name. Combined, this enables a conformant implementation.

I think we should consider removing the legacy configuration option in the Contour controller (and associated implementation logic) from Contour at this point, as it does not contribute to a conformant implementation. If we do decide to remove it, we probably need to officially deprecate it in 1.28 and look at removing it in 1.29.
@skriss skriss added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Oct 31, 2023
@skriss skriss added this to the 1.28.0 milestone Oct 31, 2023
@skriss skriss added this to Contour Oct 31, 2023
@skriss skriss mentioned this issue Oct 31, 2023
Closed
5 tasks
@skriss skriss moved this to Todo in Contour Oct 31, 2023
@skriss skriss self-assigned this Jan 29, 2024
skriss added a commit to skriss/contour that referenced this issue Jan 29, 2024
@skriss
deprecate configuring Contour with a Gateway controller name
7bfcc62 
Users should either statically configure Contour with
a specific Gateway ref, or use the Gateway provisioner
to dynamically provision Gateways.

Updates projectcontour#5923.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
skriss added a commit to skriss/contour that referenced this issue Jan 29, 2024
@skriss
deprecate configuring Contour with a Gateway controller name
e3d6c6b 
Users should either statically configure Contour with
a specific Gateway ref, or use the Gateway provisioner
to dynamically provision Gateways.

Updates projectcontour#5923.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss mentioned this issue Jan 29, 2024
Merged
@skriss skriss moved this from Todo to In Progress in Contour Jan 29, 2024
@skriss skriss modified the milestones: 1.28.0, 1.29.0 Jan 29, 2024
@skriss
Copy link
Member Author

skriss commented Jan 29, 2024

Opened a PR to deprecate the field in 1.28, will plan to remove it in 1.29.

skriss added a commit that referenced this issue Jan 31, 2024
@skriss
deprecate configuring Contour with a Gateway controller name (#6144)
62f81db 
Users should either statically configure Contour with
a specific Gateway ref, or use the Gateway provisioner
to dynamically provision Gateways.

Updates #5923.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss changed the title consider dropping Contour config file's gateway.controllerName option drop Contour config file's gateway.controllerName option Jan 31, 2024
@skriss skriss moved this from In Progress to Todo in Contour Jan 31, 2024
@skriss skriss moved this from Todo to In Progress in Contour Jan 31, 2024
@skriss skriss mentioned this issue Feb 1, 2024
Merged
skriss added a commit that referenced this issue Feb 13, 2024
@skriss
Gateway API: remove gateway controller name config option (#6145)
1cc89d0 
Closes #5923.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Contour Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation.
Projects
Contour
Status: Done
Milestone
1.29.0
Development

Successfully merging a pull request may close this issue.

Gateway API: remove gateway controller name config option skriss/contour
1 participant
@skriss