-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawn Upstream Span when Tracing is enabled #6270
Comments
Hey @SamMHD! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
I'll be happy to hear your opinions on it. |
Yep that sounds totally reasonable to me +1 to adding that |
Looks like you've started a PR @SamMHD, thanks! I'll assign this issue to you as well |
Thank you @sunjayBhatia for your review. I'll fix the issues with the PR. |
As described in Envoy documentations, when tracing is enabled and envoy is working as an independent proxy, It's better to set
spawn_upstream_span
to true and that seems reasonable because mostly when we are using envoy with Contour we would like to see it's tracing spans as an independent hop in tracing records.Right now it is something like this:
So contour managed envoy spans will be at same level as the upstream spans are because both upstream and envoy are using same parent span. So I think it's more convenient to spawn a new span for upstream to show this service hop in request traces.
The text was updated successfully, but these errors were encountered: