Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn Upstream Span when Tracing is enabled #6270

Closed
SamMHD opened this issue Mar 14, 2024 · 5 comments · Fixed by #6271
Closed

Spawn Upstream Span when Tracing is enabled #6270

SamMHD opened this issue Mar 14, 2024 · 5 comments · Fixed by #6271
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@SamMHD
Copy link
Contributor

SamMHD commented Mar 14, 2024

As described in Envoy documentations, when tracing is enabled and envoy is working as an independent proxy, It's better to set spawn_upstream_span to true and that seems reasonable because mostly when we are using envoy with Contour we would like to see it's tracing spans as an independent hop in tracing records.

Right now it is something like this:
Screenshot 1402-12-25 at 00 30 58

So contour managed envoy spans will be at same level as the upstream spans are because both upstream and envoy are using same parent span. So I think it's more convenient to spawn a new span for upstream to show this service hop in request traces.

@SamMHD SamMHD added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Mar 14, 2024
Copy link

Hey @SamMHD! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

@SamMHD
Copy link
Contributor Author

SamMHD commented Mar 14, 2024

I'll be happy to hear your opinions on it.

@sunjayBhatia
Copy link
Member

Yep that sounds totally reasonable to me +1 to adding that

@sunjayBhatia sunjayBhatia removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Mar 25, 2024
@sunjayBhatia
Copy link
Member

Looks like you've started a PR @SamMHD, thanks! I'll assign this issue to you as well

@SamMHD
Copy link
Contributor Author

SamMHD commented Mar 26, 2024

Thank you @sunjayBhatia for your review. I'll fix the issues with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants