set SpawnUpstreamSpan to true for generation new span #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjayBhatia
requested review from
a team,
davinci26 and
clayton-gonsalves
and removed request for
a team
|
Hi @SamMHD! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
sunjayBhatia
added
the
release-note/minor
There was a problem hiding this comment.
Thanks for the PR @SamMHD! Looks like this change needs a release note and an update to unit tests to verify the configuration change you've made
|
Alright dear @sunjayBhatia, I'll fix them. |
Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6271 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 133 133
Lines 15801 15802 +1
=======================================
+ Hits 12888 12889 +1
Misses 2617 2617
Partials 296 296
|
sunjayBhatia
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6270
see: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto#extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-tracing