Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable the make staticcheck target #956

Closed
davecheney opened this issue Mar 21, 2019 · 1 comment
Closed

Reenable the make staticcheck target #956

davecheney opened this issue Mar 21, 2019 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
0.13.0

Comments

@davecheney
Copy link
Contributor

staticcheck OOMs in go module mode, see dominikh/go-tools#419.

Reenable the staticcheck target in make check once the bug is fixed in staticcheck.
@davecheney davecheney added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 21, 2019
@davecheney davecheney added this to the 0.11.0 milestone Mar 21, 2019
@davecheney davecheney modified the milestones: 0.11.0, 0.12.0 Apr 8, 2019
@davecheney davecheney added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 9, 2019
@davecheney
Copy link
Contributor Author

The upstream issue has been improved. If someone wants to address this issue the first step is

go get -u honnef.co/go/tools/cmd/staticcheck

inside the heptio/contour directory -- make sure you are running go 1.12 or later.

Then readd the staticcheck target to make test

The fix any errors reported

Then wrap the whole in thing in a PR that closes this issue.

@stevesloka stevesloka added this to the 0.13.0 milestone Apr 23, 2019
@rohandvora rohandvora self-assigned this Apr 24, 2019
rohandvora pushed a commit to rohandvora/contour that referenced this issue Apr 24, 2019
Re-enable staticcheck
3171235 
Adds back staticcheck to make check target.

Updates: projectcontour#956
Signed-off-by: Rohan Vora <vorar@vmware.com>
@rohandvora rohandvora mentioned this issue Apr 24, 2019
Merged
rohandvora pushed a commit to rohandvora/contour that referenced this issue Apr 24, 2019
Re-enable staticcheck
fb24e7d 
Adds back staticcheck to the make check target.

Updates: projectcontour#956
Signed-off-by: Rohan Vora <vorar@vmware.com>
rohandvora pushed a commit to rohandvora/contour that referenced this issue Apr 24, 2019
Re-enable staticcheck
8d6391f 
Adds back staticcheck to the make check target.

Updates: projectcontour#956
Signed-off-by: Rohan Vora <vorar@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
3 participants
@davecheney @stevesloka @rohandvora