Add gRPC over TLS support #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngnick
requested review from
davecheney and
stevesloka
and removed request for
davecheney
Fixes projectcontour#862 Updates projectcontour#881 - Make it clear that all three TLS params are required if you supply any in all three modes. - Update `contour serve` variables to make it clear they're not client certs. - Remove redundant test now that all three params are required. - Fix a small linting thing in `cli.go` by adding comments to exported functions. - Add secure-local Make target - Add env var support for all the TLS flags. Signed-off-by: Nick Young <ynick@vmware.com>
youngnick
force-pushed
the
fixedissues/862
branch
from
1eea494
to
2296dfd
Compare
davecheney
approved these changes
Jun 28, 2019
- Take TODO about tidying up the repo root dir - use varargs correctly in `Dial()` - other style changes - rebase from current master Signed-off-by: Nick Young <ynick@vmware.com>
youngnick
force-pushed
the
fixedissues/862
branch
from
b934836
to
8ba660f
Compare
Signed-off-by: Nick Young <ynick@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #862
Updates #881
contour servevariables to make it clear they're not client certs.cli.goby adding comments to exported functions.