cmd/contour: add -c config-path flag #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes projectcontour#1130 This PR adds the ability to supply configuration values to contour serve from a configuration file. Some gymnastics are required to make this work with kingpin and keep the precidence of config file -> env vars -> cli flags. At the moment only a few values are plumbed into the config file, mainly to keep the linter's happy. More will be added in 0.15. Signed-off-by: Dave Cheney <dave@cheney.net>
To keep the linters happy, expose a few serveContext values via -c configfile. Signed-off-by: Dave Cheney <dave@cheney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1130
This PR adds the ability to supply configuration values to contour serve
from a configuration file. Some gymnastics are required to make this
work with kingpin and keep the precedence of config file -> env vars ->
cli flags.
At the moment only a few values are plumbed into the config file, mainly
to keep the linters happy. More will be added in 0.15.
Signed-off-by: Dave Cheney dave@cheney.net