design: JSON logging #1485
Merged
design: JSON logging #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngnick
force-pushed
the
624-design
branch
from
6dfcfab
to
4feb661
Compare
1 task
davecheney
approved these changes
Sep 12, 2019
| - duration | ||
| - request_method | ||
| - ...more fields | ||
| - @timestamp |
There was a problem hiding this comment.
will yaml accept an unquoted @timestamp?
stevesloka
approved these changes
Sep 12, 2019
|
@youngnick please squash this and merge -- in the future git commit --amend is your friend. I've no idea how the rest of the world feels about force push, but as long as its your PR I prefer a clean single commit and i'm 105% ok on rewriting that commit as many times as needed. |
|
@youngnick once you've merged this can you please close the other PR's with json design and follow up on #624 to indicate this is our chosen design and when you plan to land this work. |
Updates projectcontour#624 Signed-off-by: Nick Young <ynick@vmware.com>
youngnick
force-pushed
the
624-design
branch
from
74d9119
to
e59eb23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #624
Signed-off-by: Nick Young ynick@vmware.com