Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: tune codecov settings #2512

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented May 11, 2020

Add a default codecov settings file, and make the codecov/project
status informational, since it otherwise makes CI look broken.

Signed-off-by: James Peach jpeach@vmware.com

Add a default codecov settings file, and make the `codecov/project`
status informational, since it otherwise makes CI look broken.

Signed-off-by: James Peach <jpeach@vmware.com>
@jpeach jpeach force-pushed the add-codecov-yaml branch from 0f0e687 to f8dd24a Compare May 11, 2020 01:25
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #2512 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2512      +/-   ##
==========================================
- Coverage   76.67%   76.63%   -0.04%     
==========================================
  Files          68       68              
  Lines        5513     5513              
==========================================
- Hits         4227     4225       -2     
- Misses       1191     1192       +1     
- Partials       95       96       +1     
Impacted Files Coverage Δ
internal/dag/cache.go 95.25% <0.00%> (-0.73%) ⬇️

@jpeach jpeach requested review from stevesloka and youngnick May 11, 2020 01:31
@jpeach
Copy link
Contributor Author

jpeach commented May 11, 2020

@stevesloka @youngnick Pretty sure that this is the same codecov config that we get with the defaults. The change is that the codecov/project entry in the CI checks won't ever be marked as failed (the codecov/patch entry could still be), so PRs won't seem to get penalized when they reduce the overall coverage (we don't generally worry about that in reviews).

PTAL

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll see how the coverage one goes.

@jpeach jpeach merged commit e6d1c78 into projectcontour:master May 11, 2020
@jpeach jpeach deleted the add-codecov-yaml branch May 11, 2020 02:56
@jpeach jpeach added this to the 1.5.0 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants