-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/featuretests: add simple HTTPProxy fixtures #2519
Conversation
@stevesloka @youngnick Let me know what you think of this approach. We can remove a bit more boilerplate by adding more fluent helpers and extending to other types. |
Codecov Report
@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
+ Coverage 76.97% 77.05% +0.08%
==========================================
Files 68 70 +2
Lines 5707 5732 +25
==========================================
+ Hits 4393 4417 +24
- Misses 1218 1219 +1
Partials 96 96
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. We might also need a .WithNamespace()
or something to allow different namespaces, but obviously can come when needed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I really like this, it will let us remove the package-specific fixtures.
cf93c75
to
145d623
Compare
FWIW the Travis checks passed but the GitHub status wasn't updated. |
Add some simple helpers to generate HTTPProxy test fixtures. This helps reduce some boilerplate in setting up test cases. Signed-off-by: James Peach <jpeach@vmware.com>
145d623
to
2d14850
Compare
Add some simple helpers to generate HTTPProxy test fixtures. This
helps reduce some boilerplate in setting up test cases.
Signed-off-by: James Peach jpeach@vmware.com