Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/sorter: remove xDS v2 sorters #3128

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

skriss
Copy link
Member

@skriss skriss commented Nov 16, 2020

Updates #1898.

Signed-off-by: Steve Kriss krisss@vmware.com

Updates projectcontour#1898.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #3128 (96a9388) into main (35e2013) will increase coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   72.77%   74.06%   +1.28%     
==========================================
  Files          96       96              
  Lines        6080     5977     -103     
==========================================
+ Hits         4425     4427       +2     
+ Misses       1558     1454     -104     
+ Partials       97       96       -1     
Impacted Files Coverage Δ
internal/sorter/sorter.go 95.28% <ø> (+46.95%) ⬆️
internal/dag/cache.go 96.13% <0.00%> (+0.77%) ⬆️

@skriss skriss requested a review from stevesloka November 16, 2020 16:19
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevesloka stevesloka merged commit 4f893a6 into projectcontour:main Nov 16, 2020
@skriss skriss deleted the rm-v2-sorters branch November 16, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants